Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Dependencies accept breaking change to mkdirp, causing library to fail #87

Closed
mgabeler-lee-6rs opened this issue Jan 24, 2020 · 2 comments · May be fixed by #88
Closed

Dependencies accept breaking change to mkdirp, causing library to fail #87

mgabeler-lee-6rs opened this issue Jan 24, 2020 · 2 comments · May be fixed by #88

Comments

@mgabeler-lee-6rs
Copy link

The dependency on mkdirp in this library is "*" ... and mkdirp just published a complete rewrite which completely breaks this package -- 0/4 tests pass.

I suspect this is the source of my woes at microsoft/rushstack#1713
This was referenced Jan 24, 2020
Closed
Open
@KarishmaGhiya KarishmaGhiya mentioned this issue Jan 25, 2020
Closed
@AArnott
Copy link

AArnott commented Feb 5, 2020

mkdirp-promise becomes irrelevant because the 1.0.x release of mkdirp itself returns a promise.
So the 'fix' for this should be to republish mkdirp-promise with a dependency version constraint of < 1.0

@ahmadnassri
Copy link
Owner

see #89

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: lock mkdirp dependency at compatible version
3 participants
@AArnott @ahmadnassri @mgabeler-lee-6rs