Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pull request an input #34

Open
aebrahim opened this issue Apr 2, 2022 · 1 comment
Open

Make pull request an input #34

aebrahim opened this issue Apr 2, 2022 · 1 comment

Comments

@aebrahim
Copy link

aebrahim commented Apr 2, 2022

GitHub security best practices suggest putting commenting workflows separate (details)

I have my workflow output the json and txt diffs as artifacts, and would like to call this action from a dependent workflow with those files - but this isn't currently possible because this action fails to get the pull request metadata from the dependent workflow.

Can we add an optional input for pull request number?

Many thanks for the awesome plugin!
@ahmadnassri
Copy link
Owner

this is a good idea, a Pull Request is welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahmadnassri @aebrahim