-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crash on trying to enter File or Edit menu (not View or Help) "Invalid borders specified for theme pixmap", Breeze theme #126
Comments
It doesn't crash using the Adapta theme. Still no numbers though. |
I installed the Breeze GTK theme on this laptop, and it does replicate the crash. Pretty weird!! I suspect it's an issue with the theme itself, but I will look into further later today. Thanks! |
After some investigration, I believe this is a Breeze theme issue, where the border setting for the menu separator line doesn't work with the 20x1 pixel line-h.png file. I couldn't figure out how to fix the theme locally. The workaround is to comment out the code in mainwnd that adds the SeparatorElem (horizontal lines) in the menu. I might provide a macro for that, but fixing the theme would be better. |
Okay, I found an edit to the theme that prevents the crash. However, instead of a line separator in menus that have a separator, you will see just some extra vertical space. To implement the workaround: As root, edit /usr/share/themes/gtk-2.0/Breeze/gtkrc (or gtk-3.0/gtkrc?). Find the second occurrence of "../assets/line-h.png", in the "separator_menu_item" section, and comment out the "file" and "border" lines. You might try playing with editing the PNG file and tweaking the border sections, if you're keen to dig into Gtkrc settings :-D |
I ran this scenario through valgrind, and the segfault (SIGTRAP) stack trace shows no code from seq64. I'm tempted to close it. @milkmiruku what do you mean by "still no numbers though"? Thanks! |
@ahlstromcj that was just my misinterpretation of the config, but this issue is resolved with the latest tempo_track build :) Edit; maybe I was mistaken, thinking about another issue. Editing the theme does resolve, though my thought was that a crash might be avoidable, but maybe it's not. It seems the theme is incorrect, though maybe the moving target of the GTK API/versions is also a factor. |
I am also having a similar problem. Editing the breeze theme does not seem like a reasonable solution to this issue. Whenever a new update to the breeze theme comes out it will probably cause issues again. If this is a problem with breeze, the issue should be sent upstream for resolution. |
Unfortunately, the only thing we can do on seq64's end is add a krufty option to not add separators to seq64 menus. Another option is to use the Qt version of seq64 instead. That will ultimately become the main version, but it currently still has a few issue that will be fixed in a few more revisions of the 0.96 series in the qt5_reconcile branch. I think somebody said they'd reported the breeze issue upstream. For me, it is easier to avoid that theme, nice though it looks. There's also a freeze-up issue with Gtk when using hot-keys for the menu before clicking in the GUI. These issues are part of the reason why we're moving to Qt. |
I'll try another theme shortly but AFAIK Breeze is isn't that relatively uncommon a theme, or at least a crash might possibly be a rash action :)
The text was updated successfully, but these errors were encountered: