feat: migrate validation to doc_events from doctype override

check_run/hooks.py

@@ -93,25 +93,26 @@
 # ---------------
 # Override standard doctype classes
 
-override_doctype_class = {"Bank": "check_run.overrides.bank.CustomBank"}
+# override_doctype_class = {"Bank": "check_run.overrides.bank.CustomBank"}
 
 # Document Events
 # ---------------
 # Hook on document methods and events
 
 doc_events = {
-	"Payment Entry": {
-		"on_submit": "check_run.overrides.payment_entry.update_check_number",
-	},
-	"Purchase Invoice": {
-		"before_cancel": ["check_run.check_run.disallow_cancellation_if_in_check_run"]
-	},
+	"Bank": {"validate": ["check_run.overrides.bank.validate"]},
 	"Expense Claim": {
 		"before_cancel": ["check_run.check_run.disallow_cancellation_if_in_check_run"]
 	},
 	"Journal Entry": {
 		"before_cancel": ["check_run.check_run.disallow_cancellation_if_in_check_run"]
 	},
+	"Payment Entry": {
+		"on_submit": "check_run.overrides.payment_entry.update_check_number",
+	},
+	"Purchase Invoice": {
+		"before_cancel": ["check_run.check_run.disallow_cancellation_if_in_check_run"]
+	},
 }
 
 # Scheduled Tasks

check_run/overrides/bank.py

@@ -1,28 +1,24 @@
 import frappe
-from frappe import _
-from frappe.utils import cint, flt
 
-from erpnext.accounts.doctype.bank.bank import Bank
 
-
-class CustomBank(Bank):
-	def validate(self):
-		# Canadian banking institutions limit DFI Routing Numbers to 8 characters
-		countries = frappe.db.sql(
-			"""
-			select a.country
-			from `tabAddress` a, `tabDynamic Link` dl
-			where dl.parent = a.name and dl.parenttype = 'Address'
-			and dl.link_doctype = 'Bank' and dl.link_name = %s
-			""",
-			(self.name),
-			as_dict=True,
-		)
-		if "Canada" in [c["country"] for c in countries]:
-			if len(self.aba_number) > 8:
-				frappe.throw(
-					_(
-						"This Bank is linked to at least one Canadian address. Canadian banking institutions require the ABA Number must not exceed 8 characters."
-					)
+@frappe.whitelist()
+def validate(doc, method=None):
+	# Canadian banking institutions limit DFI Routing Numbers to 8 characters
+	countries = frappe.db.sql(
+		"""
+		select a.country
+		from `tabAddress` a, `tabDynamic Link` dl
+		where dl.parent = a.name and dl.parenttype = 'Address'
+		and dl.link_doctype = 'Bank' and dl.link_name = %s
+		""",
+		(doc.name),
+		as_dict=True,
+	)
+	if "Canada" in [c["country"] for c in countries]:
+		if len(doc.aba_number) > 8:
+			frappe.throw(
+				frappe._(
+					"This Bank is linked to at least one Canadian address. Canadian banking institutions require the ABA Number must not exceed 8 characters."
 				)
-		return
+			)
+	return