Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Payment Entry Error messages for better compatibility with Check Run #203

Closed
agritheory opened this issue Feb 1, 2024 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@agritheory
Copy link
Owner

Override validation error message in Payment Entry to show what document (PE), reference name and bill_no if it exists in validate_allocated_amount and validate_allocated_amount_with_latest_data

frappe.throw(
	f"{self.party_name} Row {d.idx} / {d.reference_name}: Allocated Amount of {d.allocated_amount} cannot be greater than outstanding amount of {d.outstanding_amount}."
)
@agritheory
Copy link
Owner Author

@basawaraj-fosserp @viralkansodiya Can you take a look at this one?

@agritheory agritheory added bug Something isn't working enhancement New feature or request labels Feb 1, 2024
@viralkansodiya
Copy link
Contributor

@agritheory will check this and update you

@viralkansodiya
Copy link
Contributor

viralkansodiya commented Feb 2, 2024

@agritheory
can we wright this msg as below, I think this looks better

f"Row {d.idx} {self.party_name} / {d.reference_name}: Allocated Amount of {d.allocated_amount} cannot be greater than outstanding amount of {d.outstanding_amount}."

msg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants