From 459ef0a0407992fa4414cdd66c39096abfde7353 Mon Sep 17 00:00:00 2001 From: Adrian Yee <22947795+adrian-yee@users.noreply.github.com> Date: Tue, 17 Dec 2024 09:19:57 +1100 Subject: [PATCH 1/3] loading state property update added do content to customise loading announcement --- packages/react/src/button/docs/overview.mdx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react/src/button/docs/overview.mdx b/packages/react/src/button/docs/overview.mdx index e02c468e861f..81c2c58c3f7e 100644 --- a/packages/react/src/button/docs/overview.mdx +++ b/packages/react/src/button/docs/overview.mdx @@ -26,6 +26,7 @@ Make sure you include a [meaningful text label](/components/button/rationale#mea - create a meaningful button label with a verb and a noun that makes the action obvious to all users - e.g. ‘Register establishment’ - avoid general labels that don’t provide full context. - e.g. ‘Click here’ - use the `loading` property to let users know their action is being processed +- customise the `loading` propety announcement to make it more contextual - add an icon if it helps users understand the action, and only in conjunction with a text label - use only one Primary button on a page. You can use more than one Secondary or Tertiary button. From c4b0bd423cb9d1924463a599516b62a4fba0a40e Mon Sep 17 00:00:00 2001 From: Matt Stow Date: Fri, 20 Dec 2024 09:24:11 +1100 Subject: [PATCH 2/3] Update packages/react/src/button/docs/overview.mdx --- packages/react/src/button/docs/overview.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/button/docs/overview.mdx b/packages/react/src/button/docs/overview.mdx index 81c2c58c3f7e..205c0688bac5 100644 --- a/packages/react/src/button/docs/overview.mdx +++ b/packages/react/src/button/docs/overview.mdx @@ -26,7 +26,7 @@ Make sure you include a [meaningful text label](/components/button/rationale#mea - create a meaningful button label with a verb and a noun that makes the action obvious to all users - e.g. ‘Register establishment’ - avoid general labels that don’t provide full context. - e.g. ‘Click here’ - use the `loading` property to let users know their action is being processed -- customise the `loading` propety announcement to make it more contextual +- customise the `loadingLabel` property announcement to make it more contextual - add an icon if it helps users understand the action, and only in conjunction with a text label - use only one Primary button on a page. You can use more than one Secondary or Tertiary button. From 2e0a11ca0c37149bcdd211f553132e3ddbe19d99 Mon Sep 17 00:00:00 2001 From: Matt Stow Date: Fri, 20 Dec 2024 09:25:19 +1100 Subject: [PATCH 3/3] Create large-eels-push.md --- .changeset/large-eels-push.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/large-eels-push.md diff --git a/.changeset/large-eels-push.md b/.changeset/large-eels-push.md new file mode 100644 index 000000000000..043aec2be128 --- /dev/null +++ b/.changeset/large-eels-push.md @@ -0,0 +1,5 @@ +--- +"@ag.ds-next/react": patch +--- + +button: Add guidance about customising `loadingLabel`.