Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Coverage extension settings #9

Open
stdavis opened this issue Aug 24, 2020 · 3 comments
Open

Remove Coverage extension settings #9

stdavis opened this issue Aug 24, 2020 · 3 comments

Comments

@stdavis
Copy link
Member

stdavis commented Aug 24, 2020

These seem more like personal preferences than standards that we want to promote. Could they be easily moved to user settings?

"coverage-gutters.showGutterCoverage": true,
"coverage-gutters.showLineCoverage": true,
"coverage-gutters.showRulerCoverage": false,
"coverage-gutters.highlightdark": "rgb(61, 153, 112, .05)",
"coverage-gutters.noHighlightDark": "rgb(255, 65, 54, .05)",
"coverage-gutters.partialHighlightDark": "rgb(255, 133, 27, .05)"

@steveoh
Copy link
Member

steveoh commented Aug 27, 2020

They definitely could. I found the defaults to be obnoxious so I thought these might be better defaults. Do you find these settings getting in your way?

@stdavis
Copy link
Member Author

stdavis commented Aug 28, 2020

Yes, I just removed them. I wanted the coverage to show just in the gutters, not the entire line. The default colors didn't bother me.
image

This is with the default for me.

I also wondered if we wanted to add ryanluker.vscode-coverage-gutters to the recommended extensions?

@steveoh
Copy link
Member

steveoh commented Aug 31, 2020

Yes we can add that extension.

The reason I dislike the default gutter coverage is because it does not allow you to click in the gutter. Therefore breakpoints cannot be set for those debugging in vscode. ryanluker/vscode-coverage-gutters#253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants