Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Surfacing of Search Result Error Messages #557

Closed
stdavis opened this issue Aug 28, 2023 · 3 comments
Closed

Better Surfacing of Search Result Error Messages #557

stdavis opened this issue Aug 28, 2023 · 3 comments
Assignees
Milestone

Comments

@stdavis
Copy link
Member

stdavis commented Aug 28, 2023

Image

Do a better job at making the error messages more obvious. Two ideas:

  • Move the error message in the results grid to the top.
  • Show the error message below the layer name in the progress sidebar.
@stdavis
Copy link
Member Author

stdavis commented Jan 10, 2024

I decided that the order in the results panel should match the search results pane so moving the error messages up to the top would not work. However, I did add a small error message to the search results panel.

Image

@stdavis stdavis assigned nathankota and unassigned stdavis Jan 12, 2024
@steveoh
Copy link
Member

steveoh commented Jan 16, 2024

one unsolicited tip, fetch is not a common word for people. The action the user completed was a search, so failed to search might be more familiar. It could also be nice to offer a way to resolve the issue. Rerun the search or could there be a button to retry the search with just that layer? Maybe a report an issue button if it happens a few times?

@nathankota
Copy link

These are great comments and ideas for future enhancements:

one unsolicited tip, fetch is not a common word for people. The action the user completed was a search, so failed to search might be more familiar. It could also be nice to offer a way to resolve the issue. Rerun the search or could there be a button to retry the search with just that layer? Maybe a report an issue button if it happens a few times?

Validating based on the primary intent of the issue. The error message that the server returns is provided now in the results pane. I also really like how the order of the layers matches between the search results and results pane 👍

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants