Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global home currency #301

Open
scionaltera opened this issue Dec 21, 2020 · 0 comments
Open

Global home currency #301

scionaltera opened this issue Dec 21, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request tech debt Refactors, tests, documentation, etc.

Comments

@scionaltera
Copy link
Member

scionaltera commented Dec 21, 2020

The current implementation assumes USD is your "default" fiat currency, and uses convertExchangePair() all over the place to make a conversion if the exchange is configured to have a different homeCurrency. It would be a really helpful refactor to be able to set a currency at the top level of the configuration rather than in every exchange. For example:

trading:
  entrySpread: 0.008
  exitTarget: 0.0050
  fixedExposure: 30
  fiatCurrency: EUR # use EUR instead of USD as the default fiat currency
  tradeTimeout: 24

  exchanges:

Setting homeCurrency on an exchange configuration should override the fiatCurrency setting. Without this, non-US users are stuck setting homeCurrency for every single exchange.

@scionaltera scionaltera added enhancement New feature or request help wanted Good candidate for contributions good first issue Good for newcomers tech debt Refactors, tests, documentation, etc. labels Dec 21, 2020
@scionaltera scionaltera added this to the v0.12.0 milestone Feb 10, 2021
@scionaltera scionaltera removed good first issue Good for newcomers help wanted Good candidate for contributions labels Feb 10, 2021
@scionaltera scionaltera self-assigned this Feb 12, 2021
@scionaltera scionaltera modified the milestones: v0.12.0, v0.13.0 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tech debt Refactors, tests, documentation, etc.
Projects
None yet
Development

No branches or pull requests

1 participant