Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully fallback to __webpack_public_path__ #12

Closed
agoldis opened this issue Sep 11, 2018 · 4 comments
Closed

Gracefully fallback to __webpack_public_path__ #12

agoldis opened this issue Sep 11, 2018 · 4 comments

Comments

@agoldis
Copy link
Owner

agoldis commented Sep 11, 2018

webpack allows users to explicitly https://webpack.js.org/guides/public-path/#on-the-fly. The plugin should respect the value of __webpack_public_path__, but still override it when a configuration option is set.

@davidmjiang
Copy link

Hi @agoldis I'd be interested in helping with this.

@agoldis
Copy link
Owner Author

agoldis commented Nov 13, 2018

@davidmjiang that's great! thank you for that! Do you need any guidance / context?

@davidmjiang
Copy link

I think I understand it. If a configuration option is set (path, variableName or methodName), then we set the value as we are doing it now. In this case, users can not change the public path using __webpack_public_path = something. If none of those are set, then we should allow users to change public path using webpack_public_path. Does that sound right?

@agoldis
Copy link
Owner Author

agoldis commented Nov 13, 2018

@davidmjiang indeed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants