Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAPI controller that return void break iOS #11

Open
dicko2 opened this issue Dec 5, 2017 · 1 comment
Open

WebAPI controller that return void break iOS #11

dicko2 opened this issue Dec 5, 2017 · 1 comment
Labels

Comments

@dicko2
Copy link
Contributor

dicko2 commented Dec 5, 2017

When a webapi controller returns void, aspnet make it return a 204 instead of 200. iOS/Safari treat this differently and prompt the user for a document download blocking off the website the instant the API method is called from ajax.

We should create a rule that forces all webapi controller methods to return data and not a void.

@dicko2 dicko2 added the Proposal label Dec 5, 2017
@Chrissx
Copy link
Contributor

Chrissx commented Dec 5, 2017

Only little concern about this the referrence that we need to add to "find" inherited members from ApiController/Controller. Should it be a new package beside Agoda.Analyzers.Web? The other parts looks easy to add I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants