Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avahi mDNS API #39

Closed
NHQ opened this issue Aug 9, 2012 · 7 comments
Closed

Avahi mDNS API #39

NHQ opened this issue Aug 9, 2012 · 7 comments

Comments

@NHQ
Copy link

NHQ commented Aug 9, 2012

http://0pointer.de/avahi-compat?s=libdns_sd&e=node

I realize this is no priority, b/c people on in the LAN are not probably using Linux. Nonetheless, I was not able to browse clients.

@agnat
Copy link
Owner

agnat commented Aug 10, 2012

You're right. It's a non issue. Not because people are not using linux (in fact they do) but because the warning is mostly about API aesthetics. The avahi guys just like their own API better. The compat library covers everything most people will ever need.

However, not being able to browse clients is serious. It works just fine for me. Which version of node are you using? Have you tried running the test suite?

@NHQ
Copy link
Author

NHQ commented Aug 11, 2012

Node version 6.18, but I will upgrade today and try again.

I just ran the tests. The test log follows. Avahi also spit this out during the test:

'The program "node" called "DNSServiceEnumerateDomains()" which is not supported (or only partially supported) in the Apple Bonjour compatibility layer of Avahi' [sic]

TEST LOG:

�[1mtest_odd_ends�[22m
[SKIPPED] probably running on ahavi
✔ DNSServiceEnumerateDomains [0/0]

�[1mtest_functional�[22m
✔ simple browsing [158/158]
✔ create ads [8/8]
[SKIPPED] write better test for browseThemAll()
✔ browseThemAll() [0/0]
✔ resolver sequence [16/16]

�[1mtest_service_type�[22m
✔ protocol helpers [3/3]
✔ makeServiceType() [6/6]
✔ json round-trip [1/1]
✔ ServiceType() constructor [3/3]
✔ illegal arguments [10/10]

�[1mtest_dns_sd�[22m
✔ DNSServiceRef [3/3]
✔ DNSServiceRegister() [20/20]
✔ DNSServiceProcessResult() [13/13]
✔ DNSServiceRefSockFD() [6/6]
✔ DNSServiceBrowse() [13/13]
✔ DNSServiceRefDeallocate() [8/8]
✔ DNSServiceResolve() [11/11]
✔ DNSServiceEnumerateDomains() [13/13]
[SKIPPED] DNSServiceGetAddrInfo() not available
✔ DNSServiceGetAddrInfo [0/0]
[SKIPPED] avahi doesn't support null values
[SKIPPED] avahi doesn't support undefined values
✔ TXTRecordRef [29/29]
✔ buildException() [24/24]
✔ exportConstants() [3/3]

OK: 348 assertions

@agnat
Copy link
Owner

agnat commented Aug 11, 2012

node v0.6.x should be fine. The message about DNSServiceEnumerateDomains() is OK, too. You ain't gonna need it. It's only needed for cross domain browsing, which I've never seen in use in the field.

Somehow the test log is missing. Could you paste it again?

@NHQ
Copy link
Author

NHQ commented Aug 11, 2012

weird, sorry

�[1mtest_odd_ends�[22m
[SKIPPED] probably running on ahavi
✔ DNSServiceEnumerateDomains [0/0]

�[1mtest_functional�[22m
✔ simple browsing [158/158]
✔ create ads [8/8]
[SKIPPED] write better test for browseThemAll()
✔ browseThemAll() [0/0]
✔ resolver sequence [16/16]

�[1mtest_service_type�[22m
✔ protocol helpers [3/3]
✔ makeServiceType() [6/6]
✔ json round-trip [1/1]
✔ ServiceType() constructor [3/3]
✔ illegal arguments [10/10]

�[1mtest_dns_sd�[22m
✔ DNSServiceRef [3/3]
✔ DNSServiceRegister() [20/20]
✔ DNSServiceProcessResult() [13/13]
✔ DNSServiceRefSockFD() [6/6]
✔ DNSServiceBrowse() [13/13]
✔ DNSServiceRefDeallocate() [8/8]
✔ DNSServiceResolve() [11/11]
✔ DNSServiceEnumerateDomains() [13/13]
[SKIPPED] DNSServiceGetAddrInfo() not available
✔ DNSServiceGetAddrInfo [0/0]
[SKIPPED] avahi doesn't support null values
[SKIPPED] avahi doesn't support undefined values
✔ TXTRecordRef [29/29]
✔ buildException() [24/24]
✔ exportConstants() [3/3]

OK: 348 assertions

@agnat
Copy link
Owner

agnat commented Aug 11, 2012

Ok, looks good to me. I'm pretty sure the bug is on your side. Is your code available somewhere so I can take a quick look?

@NHQ
Copy link
Author

NHQ commented Aug 12, 2012

LAWRD, I am such a shameful ASS!

Please forgive me! I thought I had copied working code from my other app but I left out

browser.start()

[eggface] [uhgface]

@agnat
Copy link
Owner

agnat commented Aug 12, 2012

Hey, no problem. Don't blame yourself. Stuff like this happens all the time ... to all of us. The only thing that matters is that we were able to sort it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants