[bug] SolidJs windowControlsProps is not reactive

[Eatham532]

I try to use a SolidJs signal with my titlebar to make the controls hidden and not hidden. However, when I update the signal the taskbar doesn't update.

Code:
<WindowTitlebar class={'titlebar'} windowControlsProps={{"hide":getHide()}}></WindowTitlebar>

[Rafferty97]

Here's some insight into what's happening. When you pass { "hide": gethide() } to a prop, you are not passing an object with reactive properties. Instead, Solid.JS will reconstruct the entire { hide: boolean } object any time getHide changes, and pass this to WindowTitlebar. This should work, but due to a bug in WindowTitlebar, it doesn't. It's also potentially less efficient.

Here's a workaround that might work:

<WindowTitlebar class="titlebar" windowControlsProps={{ get hide() { return getHide() } }} />