Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mike Hamburg's Ristretto #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions edwards25519/const.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ var SqrtM1 = FieldElement{
-32595792, -7943725, 9377950, 3500415, 12389472, -272473, -25146209, -2005654, 326686, 11406482,
}

var ristrettoMagic = FieldElement{
-6111485, -4156064, 27798727, -12243468, 25904040, -120897, -20826367, 7060776, -6093568, 1986012,
}

var A = FieldElement{
486662, 0, 0, 0, 0, 0, 0, 0, 0, 0,
}
Expand Down
114 changes: 114 additions & 0 deletions edwards25519/edwards25519.go
Original file line number Diff line number Diff line change
Expand Up @@ -1771,3 +1771,117 @@ func ScReduce(out *[32]byte, s *[64]byte) {
out[30] = byte(s11 >> 9)
out[31] = byte(s11 >> 17)
}

// Compute inverse squareroot
func FeInvSqrt(out, x *FieldElement) {
var den2, den3, den4, den6, chk, t, t2 FieldElement
FeSquare(&den2, x)
FeMul(&den3, &den2, x)
FeSquare(&den4, &den2)
FeMul(&den6, &den2, &den4)
FeMul(&t, &den6, x)
fePow22523(&t, &t)
FeMul(&t, &t, &den3)
FeSquare(&chk, &t)
FeMul(&chk, &chk, x)
FeMul(&t2, &t, &SqrtM1)
FeCMove(&t, &t2, 1-FeIsOne(&chk))
FeCopy(out, &t)
}

func FeIsOne(f *FieldElement) int32 {
var g, one FieldElement
FeOne(&one)
FeSub(&g, f, &one)
return 1 - FeIsNonZero(&g)
}

// Unpacks a point from its Ristretto "encoding".
// Not every curve point has a Ristretto encoding and if a curve point
// does have a Ristretto encoding, then there are three other points with
// the same encoding.
// (For the connoisseurs: the Ristretto group is a subquotient of the Edwards
// curve, which does have prime order.)
func (p *ExtendedGroupElement) FromRistrettoBytes(x *[32]byte) bool {
var s, s2, chk, yden, ynum, yden2, xden2, isr, xdeninv FieldElement
var one, zero, ydeninv, t FieldElement
var ret int32
var b byte

FeOne(&one)
FeZero(&zero)
FeFromBytes(&s, x)
ret = int32(FeIsNegative(&s))
FeSquare(&s2, &s)
FeAdd(&yden, &one, &s2)
FeSub(&ynum, &one, &s2)
FeSquare(&yden2, &yden)
FeSquare(&xden2, &ynum)
FeMul(&xden2, &xden2, &d)
FeAdd(&xden2, &xden2, &yden2)
FeNeg(&xden2, &xden2)
FeMul(&t, &xden2, &yden2)
FeInvSqrt(&isr, &t)
FeSquare(&chk, &isr)
FeMul(&chk, &chk, &t)
ret |= 1 - FeIsOne(&chk)
FeMul(&xdeninv, &isr, &yden)
FeMul(&ydeninv, &xdeninv, &isr)
FeMul(&ydeninv, &ydeninv, &xden2)
FeMul(&p.X, &s, &xdeninv)
FeAdd(&p.X, &p.X, &p.X)
b = FeIsNegative(&p.X)
FeNeg(&t, &p.X)
FeCMove(&p.X, &t, int32(b))
FeMul(&p.Y, &ynum, &ydeninv)
FeOne(&p.Z)
FeMul(&p.T, &p.X, &p.Y)
ret |= int32(FeIsNegative(&p.T))
ret |= 1 - FeIsNonZero(&p.Y)
FeCMove(&p.X, &zero, ret)
FeCMove(&p.Y, &zero, ret)
FeCMove(&p.Z, &zero, ret)
FeCMove(&p.T, &zero, ret)
return ret == 0
}

// Returns the Ristretto "encoding" of the point.
// Not every curve point has a Ristretto encoding and if a curve point
// does have a Ristretto encoding, then there are three other points with
// the same encoding.
// (For the connoisseurs: the Ristretto group is a subquotient of the Edwards
// curve, which does have prime order.)
func (p *ExtendedGroupElement) ToRistrettoBytes(r *[32]byte) {
var d, u1, u2, isr, i1, i2, zinv, deninv, nx, ny, s FieldElement
var b int32

FeAdd(&d, &p.Z, &p.Y)
FeSub(&u1, &p.Z, &p.Y)
FeMul(&u1, &u1, &d)
FeMul(&u2, &p.X, &p.Y)
FeSquare(&isr, &u2)
FeMul(&isr, &isr, &u1)
FeInvSqrt(&isr, &isr)
FeMul(&i1, &isr, &u1)
FeMul(&i2, &isr, &u2)
FeMul(&zinv, &i1, &i2)
FeMul(&zinv, &zinv, &p.T)
FeMul(&d, &zinv, &p.T)
b = 1 - int32(FeIsNegative(&d))
FeMul(&nx, &p.Y, &SqrtM1)
FeMul(&ny, &p.X, &SqrtM1)
FeMul(&deninv, &ristrettoMagic, &i1)
FeCMove(&nx, &p.X, b)
FeCMove(&ny, &p.Y, b)
FeCMove(&deninv, &i2, b)
FeMul(&d, &nx, &zinv)
b = int32(FeIsNegative(&d))
FeNeg(&d, &ny)
FeCMove(&ny, &d, b)
FeSub(&s, &p.Z, &ny)
FeMul(&s, &s, &deninv)
b = int32(FeIsNegative(&s))
FeNeg(&d, &s)
FeCMove(&s, &d, b)
FeToBytes(r, &s)
}
26 changes: 26 additions & 0 deletions edwards25519/edwards25519_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package edwards25519_test

import (
"math/rand"
"testing"

"github.com/agl/ed25519/edwards25519"
)

func TestRistretto(t *testing.T) {
var ge edwards25519.ExtendedGroupElement
var buf [32]byte
var buf2 [32]byte

for i := 0; i < 10000; i++ {
rand.Read(buf[:])
buf[31] &= 127 // clear highest bit
if !ge.FromRistrettoBytes(&buf) {
continue
}
ge.ToRistrettoBytes(&buf2)
if buf != buf2 {
t.Fatalf("ToRistrettoBytes(FromRistrettoBytes(x)) != x, (%v != %v)", buf2, buf)
}
}
}