Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registrations for groups with value 0 crash the group's page #327

Open
hugocorbucci opened this issue Oct 13, 2016 · 2 comments
Open

Registrations for groups with value 0 crash the group's page #327

hugocorbucci opened this issue Oct 13, 2016 · 2 comments

Comments

@hugocorbucci
Copy link
Member

This happened for group 81 for event 20 (Agile Brazil 2016).
The group was created as a value 0 group without a discount field entered.
Once attendances were added, the group page was failing because the total_price could not be calculated as attendances had registration_value as nil.

We worked around it by manually setting the value to 0 and changing the group to have 100% discount but there is something there to fix.

@sampatbadhe
Copy link

@hugocorbucci I can help you on this.

Is default value for registration_value is 0?

@hugocorbucci
Copy link
Member Author

Hey @sampatbadhe thanks for volunteering :)
So, registration_groups can have a specified value amount (registration_group.amount). In which case, the registration_value for an attendance in that group should be exactly that amount.
If a group is created with an amount 0, then the registration_value for any attendance in that group should be 0. Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants