Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

represent and accept ids in the form of a UUID rather than an Objectid #24

Open
kristofsajdak opened this issue Jan 26, 2015 · 2 comments
Open

represent and accept ids in the form of a UUID rather than an Objectid #24

kristofsajdak opened this issue Jan 26, 2015 · 2 comments

Comments

@kristofsajdak
Copy link

No description provided.

@kristofsajdak kristofsajdak changed the title Harvest should represent and accept ids in the form of a UUID rather than an Objectid represent and accept ids in the form of a UUID rather than an Objectid Jan 26, 2015
@kristofsajdak
Copy link
Author

I took it for a spin just now with the agco-harvest-recipes and did some manual tests, all seems to be working fine. Code looks clean as well, great work !

Can you add some tests to the codebase as well ? e.g. :

uuid ids

  1. should respond with a 201 and an id populated with a UUID value
    when an HTTP POST is invoked with a valid payload without an id
  2. should respond with a 201 and the id set to the value of the request id
    when an HTTP POST is invoked with a valid payload and a client generated id set to a UUID value

@kristofsajdak
Copy link
Author

#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kristofsajdak