Improving mongoose->mongodb dependency chain requirement. #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After starting a project from scratch, I started to receive the following error message:
Actually that happens because SSE adapter assumes that required mongodb module is located inside mongoose folder tree. This is a bad practice because if the target project has it as a dependency, it won't be downloaded into mongoose node-modules folder.
So, in order to make this "friendly" for dev community and save some hours of debugging for who is beginning with HH, I'm submitting two improvements:
#1: Add mongodb as module as a dependency for hapi-harvester and require it directly, w/o a specific path (to avoid issues when it was required already).
#2: Changed the error message when loading adapters to be friendly (because it induces the wrong direction when debugging). The matter fact is that exception is thrown when HH can't load an adapter, because it doesn't exist or because an error occurred. Still wondering how to expose the error message to tell the developer what happened exactly.