Feature/glblagctwo 1147 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks awesome, you did an amazing job here. |
| }; | ||
|
|
||
|
|
||
| //TODO just done the validation, actual sorts is remaining |
There was a problem hiding this comment.
TODO should probably be removed as basic sort seems to be implemented : https://github.com/agco/hapi-harvester/pull/1/files#diff-55a387780cc6221ae09789e1dc0f4517R34
The missing feature is support for a descending sort
There was a problem hiding this comment.
Yup, implemented descending sort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👍