From ab1c09acfa4eef0cb709eff66b92e84fb0361744 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20D=C3=ADaz=20Gonz=C3=A1lez?= Date: Wed, 21 Feb 2024 17:26:00 +0000 Subject: [PATCH 1/2] [web] Drop warning shown in storage page The regular Agama UI's workflow is to keep the system unchanged until installation begins, so warning users about it is actually not needed. Thus, we agreed to use these intrusive warnings only in cases when/where Agama will take immediate action. --- web/src/components/storage/ProposalPage.jsx | 7 ------- web/src/components/storage/ProposalPage.test.jsx | 6 ------ 2 files changed, 13 deletions(-) diff --git a/web/src/components/storage/ProposalPage.jsx b/web/src/components/storage/ProposalPage.jsx index 4d730cce93..e354ccfd93 100644 --- a/web/src/components/storage/ProposalPage.jsx +++ b/web/src/components/storage/ProposalPage.jsx @@ -20,12 +20,10 @@ */ import React, { useCallback, useReducer, useEffect } from "react"; -import { Alert } from "@patternfly/react-core"; import { _ } from "~/i18n"; import { useInstallerClient } from "~/context/installer"; import { toValidationError, useCancellablePromise } from "~/utils"; -import { Icon } from "~/components/layout"; import { Page } from "~/components/core"; import { ProposalActionsSection, @@ -210,11 +208,6 @@ export default function ProposalPage() { return ( <> - } - title={_("Devices will not be modified until installation starts.")} - /> { await screen.findByText(/\/dev\/vda/); }); -it("renders a warning about modified devices", async () => { - installerRender(); - - await screen.findByText(/Devices will not be modified/); -}); - it("renders the settings, find space and actions sections", async () => { installerRender(); From 166aa9e416cd63b3d841d320f7812e8d8d16a5e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20D=C3=ADaz=20Gonz=C3=A1lez?= Date: Wed, 21 Feb 2024 17:43:04 +0000 Subject: [PATCH 2/2] [web] Update changes file --- web/package/cockpit-agama.changes | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/web/package/cockpit-agama.changes b/web/package/cockpit-agama.changes index 43034076bc..30ae533f8b 100644 --- a/web/package/cockpit-agama.changes +++ b/web/package/cockpit-agama.changes @@ -1,3 +1,9 @@ +------------------------------------------------------------------- +Wed Feb 21 17:40:01 UTC 2024 - David Diaz + +- Stop rendering a warning at the top of storage page + (gh#openSUSE/agama#1048). + ------------------------------------------------------------------- Tue Feb 20 13:13:51 UTC 2024 - José Iván López González