Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some feedback and suggestions #13

Open
ffont opened this issue Feb 6, 2019 · 0 comments
Open

Some feedback and suggestions #13

ffont opened this issue Feb 6, 2019 · 0 comments

Comments

@ffont
Copy link
Collaborator

ffont commented Feb 6, 2019

I had the following compilation errors:

/Users/ffont/Developer/FreesoundUploader/FreesoundUploader/Source/FreesoundUpload.h:225:7: No viable conversion from 'const char [49]' to 'juce::URL'

/Users/ffont/Developer/FreesoundUploader/FreesoundUploader/Source/PluginEditor.h:571:7: No viable conversion from 'const char [43]' to 'juce::URL'

Fixed them by replacing URL url = "http://example.com"; by URL url = URL("http://example.com"); so URL constructor is used instead of converting from String. See JUCE URL class reference.

After the changes above I could compile the project. These are some comments.

  • Had to disable VST2 target to compile.
  • I can load plugin as standalone and I can log in to Freesound.
  • Plugin (AU) fails validation in Logic Pro auvaltool so I could not use it in Logic Pro.
  • Plugin loads in Bitwig Studio, I can log in to Freesound but I can't drop any audio (drop does not work).
  • Using the standalone version, I tried to upload a sound and it failed, but no error message was shown. I was not able to do any successful upload.
  • Would be nice to show uploading percentage.
  • Make username visible when logged in. You could show the user avatar.
  • Update color scheme to better match Freesound's design. Future Freesound design color scheme is similar to this: https://ffont.github.io/freesound-timeline/.
  • I wanted to open a PR with the changes in code but I don't have permissions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant