Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update plugin from private repo #929

Closed
ericp-mrel opened this issue Feb 1, 2021 · 3 comments
Closed

Unable to update plugin from private repo #929

ericp-mrel opened this issue Feb 1, 2021 · 3 comments

Comments

@ericp-mrel
Copy link

Hi,

I am trying to update a plugin of mine from a private Github repo using this plugin, but I keep getting a download failed, bad request response.

But, what's weird is when I visit the URL that it prints and visit it directly from my browser, it downloads the plugin file just fine.
I am using the Release asset: true for my plugin, so it is trying to download the asset bundle that I generate through CI. (Just like this plugin does)

Let me know if there's anything I can do to help debug this issue as I'm not really sure if there is a way to turn on logging for this plugin that would show the specific issue.

Thanks

@afragen
Copy link
Owner

afragen commented Feb 1, 2021

I see something like this in another plugin. I'm looking into it.

@afragen afragen closed this as completed in 816909f Feb 1, 2021
@afragen
Copy link
Owner

afragen commented Feb 1, 2021

It seems that AWS changed the URL for the GitHub release asset redirect and so it missed my check to remove the Auth header. Having the Auth header when not needed is what caused the error.

@afragen
Copy link
Owner

afragen commented Feb 1, 2021

Fixed in v9.9.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants