-
-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin not updating without InfiniteWP checked, not in WordPress admin even with InfiniteWP checked #321
Comments
You will get better information if you update from the update-core.php page and not the plugins.php page. That information would be helpful. |
Good call. Here's the error:
Permissions maybe? I've replicated this on local and live, two different sites. |
Definitely a permissions issue. Try adding |
Hrm. So I added that and was able to update from the "Updates" screen, but not the "Plugins" screen. Then I removed it and was still able to update from the "Updates" screen, but still got infinite spinning on "Plugins". |
Weird. I don't have any updating code in the plugin, it uses WordPress core updating methods. |
@ethanclevenger91 are you still having issues? |
I can update from the "Updates" page, but not the AJAX update from the Plugins page. That's with no plugins active other than mine that I'm updating and yours. FWIW, if I have Toolset's Types plugin installed and active, it runs a file called
Scenario 1:Given:
Result:
Scenario 2:Given:
Result:
Then:
Result:
Don't know if that's useful at all for debugging, and like I said, even with Types deactivated, the update fails. |
Still very strange. I don't have any custom updating code in the plugin. All I do is add the plugin to be updated to the appropriate array. I'll keep testing here. Could you report your environment? WordPress version, PHP version, etc? Not that it should matter but, there is a cosmetic bug when AJAX updating where the version number vanishes. |
Sure. So it's happening both on the server and locally. Local: WAMP Server: CentOS I'll try a WP install without any other plugins even there (not just deactivated), see what happens, though I don't see how that could be an issue. |
Can you update .org plugins from the plugins page? |
Can you send the URI for your plugin or add |
.org plugins update just fine. Just shared a plugin with you. There are more than that one, but the two I've tested, including that one, behave the same way. |
Thanks. I'll be able to test a bit more this evening after work. |
Ok, some quick testing shows that public Bitbucket plugins update and private Bitbucket plugins fail using shiny updates. This gives me a starting point to test. |
I think the issue has to to with AJAX updates and the fact that the Bitbucket Basic Auth is sent via an HTTP header. As there is no page load I'm guessing that no headers are sent and therefore no authorization can be done. I'll have to confirm this, but if this is accurate the eventual solution may only come when Bitbucket allows for application specific tokens like GitHub. |
Let me know if 45d1772 fixes this issue. Please update to latest develop branch. |
I know about that cosmetic bug and it may take a change to core to fix it. |
Cosmetic bug should now be fixed. It only took another rewrite of the renaming code. 😝 |
Scenario:
Result:
Scenario:
Result:
The text was updated successfully, but these errors were encountered: