Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformed auto-completion uri #1584

Closed
tedr56 opened this issue May 27, 2014 · 6 comments · May be fixed by MaxMood96/NodeBB#49, saurabharch/NodeBB#98, Mement-Mori/NodeBB#110 or afeish/NodeBB#51
Closed

Malformed auto-completion uri #1584

tedr56 opened this issue May 27, 2014 · 6 comments · May be fixed by MaxMood96/NodeBB#49, saurabharch/NodeBB#98, Mement-Mori/NodeBB#110 or afeish/NodeBB#51
Assignees
@julianlam
Labels
bug
Milestone
0.5.0

Comments

@tedr56
Copy link

tedr56 commented May 27, 2014

Assuming I have a topic called "[Jeu] - Joué" with the 13 uid.

If I enter the uri http://nodebb.website/topic/13
it redirects to
http://nodebb.website/topic/13/[jeu]-jou%E9
instead of
http://nodebb.website/topic/13/[jeu]-joué

And it shows : {"error":"URI malformed"}
Very specific I know. :-)
@tedr56 tedr56 changed the title Malformated auto-completion uri Malformed auto-completion uri May 27, 2014
@julianlam
Copy link
Member

Reproduced, although in my case, NodeBB Is redirecting to /topic/1408/jeu-jou%E9, note the missing square brackets, which is expected.

@julianlam julianlam added the bug label May 27, 2014
@julianlam julianlam added this to the 0.5.0 milestone May 27, 2014
@julianlam julianlam self-assigned this May 27, 2014
@tedr56
Copy link
Author

tedr56 commented May 27, 2014

Sorry, I meant it's redirecting to : http://nodebb.website/topic/13/jeu-jou%E9

instead of http://nodebb.website/topic/13/jeu-joué

@julianlam
Copy link
Member

Something is calling javascript escape(); on /1408/jeu-joué, instead of encodeURIComponent();, which really doesn't handle utf-8 properly...

julianlam added a commit that referenced this issue May 27, 2014
@julianlam
fixed #1584
93e3eb4
@julianlam
Copy link
Member

Give it a try @tedr56 -- that should do it.

@julianlam
Copy link
Member

Looking at the discussion regarding this issue in the express repo, there's a chance this was already fixed upstream. In any case, escaping on our end seemed to do the trick.

@tedr56
Copy link
Author

tedr56 commented May 27, 2014

All good! 👍
Thanks @julianlam

@MaxMood96 MaxMood96 mentioned this issue Feb 1, 2024
Open
@saurabharch saurabharch mentioned this issue Feb 1, 2024
Open
@MaxMood96 MaxMood96 mentioned this issue Feb 2, 2024
Open
@afeish afeish mentioned this issue Feb 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julianlam julianlam

Labels
bug
Projects
None yet
Milestone
0.5.0
2 participants
@tedr56 @julianlam