Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollup summary new page v1.0 #15

Merged
merged 5 commits into from
Apr 8, 2014
Merged

Conversation

wes1278
Copy link
Contributor

@wes1278 wes1278 commented Mar 3, 2014

Hey Andrew,

I whipped together a pretty simple page to help the creation of these lookup rollup summary records. Here are some features:

  • Select Parent Object from selectlist (filtered by anything updateable & createable,.)
  • select parent aggregate result from select list (filterd by anything accessible, updateable, and numeric/date)
  • select child record (filtered by what actually has a lookup to the parent you chose)
  • no need to type the relationship field, it's displayed for you when you're choosing the child object.
  • select child field to aggregate from select list (filtered by anything accessible, updateable, and numeric/date)

There are a few things that I was hoping you might help be able to help me with.

  • Routing to the trigger deployment method (if that's possible) so that the save event can deploy the trigger if it's not present. Right now, I have the check logic in there, but I couldn't make sense of how this trigger creation was happening in the time I had. Check the "save" method in the page controller.
  • See if there is anything you see that would "fit" into your enterprise pattern any better than I've done. I'd love to get some feedback.

Although the page is usable right now, here is a quick list of the things I'm hoping to accomplish still with this page. Let me know if you have any feedback about my ideas.

  • Decide if this page should also override the edit page or if there should be a different page.
  • Maybe use jquery.autocomplete or something similar instead of select lists. (js remoting)
  • maybe use a "step/wizard" like approach instead of shoving it all on 1 entry page. (I have a quick mini visualforce framework for these simple wizards)
  • Create a wrapper class for criteria.
  • create a parsing method to turn a where clause into a list of wrapper class objects.
  • create a creation method to turn a list of wrapper class objects into a where clause (maybe soql builder)?
  • use some javascript/jquery to add/remove/edit wrapper objects representing criteria.
  • add an input for filter logic ie 1 AND (2 or 3)

On an unrelated note, do you happen to have a repo setup to demonstrate the basis for your apex enterprise pattern? I've attended your sessions at Dreamforce and tried to rip this repo apart but I think I've biten off a little more than I can chew. I was hoping you might have a repo that had your base classes, and like a single simple example class.

On another unrelated note (sorry for so many questions), I was wondering if you use MavensMate for development? If you do, would you mind telling me how you deal with keeping your mavensmate workspace/folder working with git. I spent at least twice as much trying to get git and mavensmate to work together compared to how much time I spent on the page. In your repo's you have the src folder inside another folder. I couldn't get mavensmate to actually let me use that sub folder so I had to move things around and try to convince git to do what I wanted. (considering I'm still pretty new to git, that was also a challenge. :)

Thanks!
dlrs

Wes Weingartner and others added 5 commits February 28, 2014 22:41
…describe cache'ing; may need some better practices with apex enterprise patterns;want to add some nifty criteria adding via wrapper class with parsing method (maybe use SOQL builder?)
@afawcett
Copy link
Collaborator

afawcett commented Mar 4, 2014

Wow this is great work indeed! Thank you so much for the submission. I'll debug your issue and get this out in the next release! Do you have a Twitter handle btw?

@afawcett
Copy link
Collaborator

afawcett commented Mar 4, 2014

And yeah MavensMate can be a challange, i am on a Mac, I delete the src folder MavensMate creates and create in its place a symbolic link to the git version of the src folder.

@afawcett
Copy link
Collaborator

afawcett commented Mar 4, 2014

Oh and yeah there is a repo with sample code for the patterns, here, https://github.com/financialforcedev/fflib-apex-common-samplecode, there is also series of articles on developer force.

@afawcett
Copy link
Collaborator

afawcett commented Mar 4, 2014

I think the only thing that might be good to run with for the first release of this feature is to also support Edit, what do you think? I think for now, lets put the Mange Child Trigger button on your page as per the native page, this does separate editing/creating the rollup from deploying the trigger, which i think for now works best. Though do want to give a more streamlined UI process some thoughts for sure! Your other ideas also sound good, lets do this incrementally getting the Edit support in and Manage Child Trigger button on the page for the first release?

@afawcett
Copy link
Collaborator

@wes1278 let me know your thoughts on the above, if you can or want to do anything more, if not, cool, i'll merge and take a look at the above myslef. Thanks again for the submission, it will make a good usability addition to the tool!

@afawcett
Copy link
Collaborator

Also can you confirm your happy for the BSD license (used by the other files in this tool) to be applied to your contribution.

@wes1278
Copy link
Contributor Author

wes1278 commented Mar 10, 2014

Hey Andrew,

I think you're proposed approach is great. Make sure this page works for edit, and add your existing button to the VF page. However, I'm getting killed with work this week and can't really help at the moment. Feel free to add/subtract from my contribution as you see fit. Or, I can work on this in another week or so.

I'm totally fine with the BSD license.

Thanks!

afawcett added a commit that referenced this pull request Apr 8, 2014
rollup summary new page v1.0
@afawcett afawcett merged commit 7ed63d0 into SFDO-Community:master Apr 8, 2014
afawcett pushed a commit that referenced this pull request Apr 9, 2014
@afawcett
Copy link
Collaborator

afawcett commented Apr 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants