Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Chain): add new method waitFOrTxConfirm #874

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Jan 22, 2020

Add new option { confirm: 3 } to all of high lvl SDK API. Add tests. Adjust docs

…irm: 3 } to all of high lvl SDK API. Add tests. Adjust docs
@nduchak nduchak added this to the 7.0.0 milestone Jan 22, 2020
@nduchak nduchak self-assigned this Jan 22, 2020
@nduchak
Copy link
Contributor Author

nduchak commented Jan 22, 2020

Resolve #851

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #874 into develop will increase coverage by 12.94%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #874       +/-   ##
============================================
+ Coverage    79.74%   92.69%   +12.94%     
============================================
  Files           57       57               
  Lines         2834     2834               
============================================
+ Hits          2260     2627      +367     
+ Misses         574      207      -367
Impacted Files Coverage Δ
es/ae/aepp.js 100% <100%> (ø) ⬆️
es/account/index.js 100% <100%> (ø) ⬆️
es/utils/aepp-wallet-communication/rpc/aepp-rpc.js 100% <100%> (ø) ⬆️
es/ae/wallet.js 100% <100%> (ø) ⬆️
es/node-pool/index.js 100% <100%> (ø) ⬆️
es/utils/json-big.js 81.25% <0%> (+0.48%) ⬆️
es/contract/compiler.js 100% <0%> (+2.32%) ⬆️
es/utils/crypto.js 82.05% <0%> (+5.12%) ⬆️
es/tx/tx.js 100% <0%> (+14.45%) ⬆️
es/channel/internal.js 95.31% <0%> (+77.34%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8dabd5...783e3f7. Read the comment docs.

@nduchak nduchak merged commit 43528f9 into develop Jan 23, 2020
@nduchak nduchak deleted the feat/transaction-confirmation branch January 23, 2020 12:53
@nduchak nduchak mentioned this pull request Jan 31, 2020
@mradkov mradkov mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants