Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aens): implement aensExtendTtl function. Refactor aensUpdate #866

Merged
merged 7 commits into from
Jan 21, 2020

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Jan 17, 2020

aensUpdate now accept array of pointers

BREAKING CHANGE: Change aensUpdate method arguments

#865

aensUpdate now accept array of pointers

BREAKING CHANGE: Change aensUpdate method arguments

#865
@nduchak nduchak self-assigned this Jan 17, 2020
@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #866 into develop will decrease coverage by 0.98%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #866      +/-   ##
===========================================
- Coverage    92.92%   91.94%   -0.99%     
===========================================
  Files           57       57              
  Lines         2828     2830       +2     
===========================================
- Hits          2628     2602      -26     
- Misses         200      228      +28
Impacted Files Coverage Δ
es/ae/aens.js 64.58% <0%> (-35.42%) ⬇️
es/utils/bignumber.js 66.66% <0%> (-33.34%) ⬇️
es/tx/builder/helpers.js 88.15% <0%> (-11.85%) ⬇️
es/ae/index.js 94.28% <0%> (-5.72%) ⬇️
es/utils/crypto.js 81.19% <0%> (-0.86%) ⬇️
es/channel/handlers.js 80.18% <0%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e21532...a93a3a4. Read the comment docs.

@mradkov
Copy link
Contributor

mradkov commented Jan 17, 2020

Great! Will this be included in v7.0.0 ?

@nduchak
Copy link
Contributor Author

nduchak commented Jan 17, 2020

Yes, it will

@nduchak
Copy link
Contributor Author

nduchak commented Jan 17, 2020

Resolve #865

Copy link
Contributor

@mradkov mradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just some minor docs typos.

docs/api/ae/aens.md Show resolved Hide resolved
es/ae/aens.js Outdated Show resolved Hide resolved
@nduchak nduchak merged commit 72b073a into develop Jan 21, 2020
@nduchak nduchak deleted the feat/aens-extend branch January 21, 2020 14:55
@nduchak nduchak mentioned this pull request Jan 22, 2020
@davidyuk
Copy link
Member

it seems that I can't find where aensExtendTtl is defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants