Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Test): Increase code covarage #830

Merged
merged 16 commits into from
Dec 16, 2019
Merged

feat(Test): Increase code covarage #830

merged 16 commits into from
Dec 16, 2019

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Dec 13, 2019

No description provided.

@nduchak nduchak added the enhancement New feature or request label Dec 13, 2019
@nduchak nduchak self-assigned this Dec 13, 2019
@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #830 into develop will decrease coverage by 29.84%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #830       +/-   ##
============================================
- Coverage    86.87%   57.02%   -29.85%     
============================================
  Files           45       40        -5     
  Lines         2423     1878      -545     
============================================
- Hits          2105     1071     -1034     
- Misses         318      807      +489
Impacted Files Coverage Δ
es/chain/node.js 58.33% <ø> (-22.92%) ⬇️
es/contract/compiler.js 32.55% <50%> (-53.49%) ⬇️
es/ae/oracle.js 8% <0%> (-90%) ⬇️
es/contract/aci/transformation.js 2.91% <0%> (-83.22%) ⬇️
es/utils/mptree.js 3.92% <0%> (-76.48%) ⬇️
es/ae/contract.js 20% <0%> (-70.91%) ⬇️
es/contract/aci/index.js 26.82% <0%> (-70.74%) ⬇️
es/contract/ga/index.js 30.43% <0%> (-69.57%) ⬇️
es/contract/aci/helpers.js 6.89% <0%> (-68.97%) ⬇️
es/tx/tx.js 39.32% <0%> (-58.43%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475c2aa...4ea9a26. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #830 into develop will increase coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #830      +/-   ##
===========================================
+ Coverage    86.54%   87.41%   +0.86%     
===========================================
  Files           45       45              
  Lines         2423     2423              
===========================================
+ Hits          2097     2118      +21     
+ Misses         326      305      -21
Impacted Files Coverage Δ
es/channel/handlers.js 79.72% <0%> (+0.45%) ⬆️
es/tx/builder/helpers.js 93.75% <0%> (+1.56%) ⬆️
es/tx/tx.js 100% <0%> (+2.24%) ⬆️
es/node-pool/index.js 100% <0%> (+3.22%) ⬆️
es/chain/node.js 95.83% <0%> (+14.58%) ⬆️
es/chain/index.js 100% <0%> (+20%) ⬆️
es/contract/aci/helpers.js 100% <0%> (+24.13%) ⬆️
es/utils/bignumber.js 100% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475c2aa...9a1221d. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #830 into develop will decrease coverage by 11.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #830       +/-   ##
============================================
- Coverage    86.54%   74.86%   -11.68%     
============================================
  Files           45       45               
  Lines         2423     2423               
============================================
- Hits          2097     1814      -283     
- Misses         326      609      +283
Impacted Files Coverage Δ
es/ae/oracle.js 8% <0%> (-90%) ⬇️
es/utils/mptree.js 3.92% <0%> (-76.48%) ⬇️
es/utils/keystore.js 24% <0%> (-76%) ⬇️
es/contract/ga/index.js 30.43% <0%> (-69.57%) ⬇️
es/utils/hd-wallet.js 20% <0%> (-60%) ⬇️
es/oracle/node.js 50% <0%> (-50%) ⬇️
es/utils/amount-formatter.js 50% <0%> (-50%) ⬇️
es/ae/index.js 60% <0%> (-31.43%) ⬇️
es/contract/ga/helpers.js 63.63% <0%> (-27.28%) ⬇️
es/utils/bytes.js 45.83% <0%> (-25.01%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475c2aa...7422062. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #830 into develop will decrease coverage by 11.76%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #830       +/-   ##
============================================
- Coverage    86.54%   74.78%   -11.77%     
============================================
  Files           45       45               
  Lines         2423     2423               
============================================
- Hits          2097     1812      -285     
- Misses         326      611      +285
Impacted Files Coverage Δ
es/ae/oracle.js 8% <0%> (-90%) ⬇️
es/utils/mptree.js 3.92% <0%> (-76.48%) ⬇️
es/utils/keystore.js 24% <0%> (-76%) ⬇️
es/contract/ga/index.js 30.43% <0%> (-69.57%) ⬇️
es/utils/hd-wallet.js 20% <0%> (-60%) ⬇️
es/oracle/node.js 50% <0%> (-50%) ⬇️
es/utils/amount-formatter.js 50% <0%> (-50%) ⬇️
es/ae/index.js 60% <0%> (-31.43%) ⬇️
es/contract/ga/helpers.js 63.63% <0%> (-27.28%) ⬇️
es/utils/bytes.js 45.83% <0%> (-25.01%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475c2aa...7422062. Read the comment docs.

@nduchak nduchak merged commit 6f760fb into develop Dec 16, 2019
@nduchak nduchak deleted the feat/increase-code-cove branch December 16, 2019 14:22
@nduchak nduchak mentioned this pull request Dec 18, 2019
@nduchak nduchak mentioned this pull request Jan 14, 2020
@mradkov mradkov mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants