feat(Node): Avoid usage of "universal-url" package #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nduchak
previously approved these changes
May 21, 2019
davidyuk
force-pushed
the
feature/drop-url-package
branch
from
74f36cd
to
5f5b96c
Compare
|
@davidyuk Please fix test. |
nduchak
changed the title
davidyuk
force-pushed
the
feature/drop-url-package
branch
from
ad9f881
to
d23a636
Compare
davidyuk
force-pushed
the
feature/drop-url-package
branch
from
d23a636
to
2cf31fd
Compare
nduchak
approved these changes
May 29, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing of
universal-urlpackage saves ~340kb.Bundle report of Identity app example before:
After: