-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve channel tests and error handling #276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpowaga
changed the title
[WIP] Improve channel tests
[WIP] Improve channel tests and error handling
Mar 6, 2019
mpowaga
changed the title
[WIP] Improve channel tests and error handling
Improve channel tests and error handling
Mar 7, 2019
nduchak
approved these changes
Mar 29, 2019
mpowaga
added a commit
that referenced
this pull request
Apr 1, 2019
* Make sure that sign function is correctly called * Improve error handling for update method
nduchak
pushed a commit
that referenced
this pull request
Apr 2, 2019
* Add support for contracts in state channels * Remove console.log * Remove console.log * Improve channel rpc usage (#275) * Improve channel rpc usage * Fix lint error * Remove unreachable code * Improve channel tests and error handling (#276) * Make sure that sign function is correctly called * Improve error handling for update method * Improve state channel params handling. Fixes #299 (#300)
mpowaga
added a commit
that referenced
this pull request
Apr 2, 2019
* Make sure that sign function is correctly called * Improve error handling for update method
mpowaga
added a commit
that referenced
this pull request
Apr 2, 2019
* Add support for contracts in state channels * Remove console.log * Remove console.log * Improve channel rpc usage (#275) * Improve channel rpc usage * Fix lint error * Remove unreachable code * Improve channel tests and error handling (#276) * Make sure that sign function is correctly called * Improve error handling for update method * Improve state channel params handling. Fixes #299 (#300)
nduchak
pushed a commit
that referenced
this pull request
Apr 16, 2019
* Improve channel rpc usage * Fix lint error * Remove unreachable code * Make sure that sign function is correctly called * Improve error handling for update method * Add missing channel tx serializations * Add channel close solo and settle tx serialization * Add channel slash tx serialization * Add proof of inclusion tx serialization * Add basic merkle patricia tree implementation * Add merkle patricia tree serialization and verify function * fix(schema.js): Fix linter error * Improve channel tests and error handling (#276) * Make sure that sign function is correctly called * Improve error handling for update method * Improve state channel params handling. Fixes #299 (#300) * Compiler improvements (#303) * refactor(Chain and Contract): Fix Chain.getAccount. Omprove Compiler Add ability to get account/balance on specific block hash/height. Add test. Add changeCompilerUrl to Compiler stamp #302 * fix(Crypto): Fix name hash function arguments parsing * refactor(Compiler): Remove async for changeCompilerUrl function * Channel contracts (#279) * Add support for contracts in state channels * Remove console.log * Remove console.log * Improve channel rpc usage (#275) * Improve channel rpc usage * Fix lint error * Remove unreachable code * Improve channel tests and error handling (#276) * Make sure that sign function is correctly called * Improve error handling for update method * Improve state channel params handling. Fixes #299 (#300) * Fix channel tests * Add contract call tx serialization * Add channel tx serialization * Add missing tree tx serializations * Add channel snapshot solo tx serialization
nduchak
pushed a commit
that referenced
this pull request
Apr 24, 2019
* Improve channel rpc usage * Fix lint error * Remove unreachable code * Make sure that sign function is correctly called * Improve error handling for update method * Add missing channel tx serializations * Add channel close solo and settle tx serialization * Add channel slash tx serialization * Add proof of inclusion tx serialization * Add basic merkle patricia tree implementation * Add merkle patricia tree serialization and verify function * fix(schema.js): Fix linter error * Improve channel tests and error handling (#276) * Make sure that sign function is correctly called * Improve error handling for update method * Improve state channel params handling. Fixes #299 (#300) * Compiler improvements (#303) * refactor(Chain and Contract): Fix Chain.getAccount. Omprove Compiler Add ability to get account/balance on specific block hash/height. Add test. Add changeCompilerUrl to Compiler stamp #302 * fix(Crypto): Fix name hash function arguments parsing * refactor(Compiler): Remove async for changeCompilerUrl function * Channel contracts (#279) * Add support for contracts in state channels * Remove console.log * Remove console.log * Improve channel rpc usage (#275) * Improve channel rpc usage * Fix lint error * Remove unreachable code * Improve channel tests and error handling (#276) * Make sure that sign function is correctly called * Improve error handling for update method * Improve state channel params handling. Fixes #299 (#300) * Fix channel tests * feat(State Channels): Ping every 10 seconds to persist connection Connection can be manually closed with new "disconnect()" method * Register pong timeout after ping has been sent * Add contract call tx serialization * Add channel tx serialization * Add missing tree tx serializations * Add channel snapshot solo tx serialization * feat(State Channels): Ping every 10 seconds to persist connection Connection can be manually closed with new "disconnect()" method * Register pong timeout after ping has been sent * Handle unexpected messages * Fix lint error
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.