Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default mode for the terminal should be the canonical mode #17

Closed
gnodet opened this issue Apr 4, 2017 · 3 comments
Closed

The default mode for the terminal should be the canonical mode #17

gnodet opened this issue Apr 4, 2017 · 3 comments
Assignees

Comments

@gnodet
Copy link
Contributor

gnodet commented Apr 4, 2017

The raw mode should only be used "locally" and should not be the default mode.
The raw mode should be entered when the line reading process is started and exited when the line has been read and will be given to the request handler (or the readline method is exited with an exception).

@stalep
Copy link
Member

stalep commented Apr 5, 2017

I'm not against this, I just want to understand the reason to do this?
This will usually cause æsh to set/reset the tty settings very often, what is the benefit of this?

@gnodet
Copy link
Contributor Author

gnodet commented Apr 5, 2017

It's more in line with what a unix system does with the terminal. Commands that require the terminal to be in raw mode are not usual: it includes things like the less pager, an ssh client, full size applications. Other usual commands just expect the terminal to be in the canonical mode. If you don't, the command won't be able to use System.in in the usual way for example.

@stalep
Copy link
Member

stalep commented May 17, 2017

I understand your reasoning behind this. It makes it a bit "harder" for developers to write commands though, but i understand why. I need to think about this a bit.

@stalep stalep self-assigned this May 28, 2017
@stalep stalep closed this as completed in 2e81ed5 May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants