Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not embedding aerolab binaries in other binaries #224

Open
robertglonek opened this issue Jan 2, 2024 · 1 comment
Open

Consider not embedding aerolab binaries in other binaries #224

robertglonek opened this issue Jan 2, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@robertglonek
Copy link
Collaborator

Currently to handle arm to amd as well as amd to arm deployments and macos to linux deployments, different binaries need to embed other aerolab versions. Consider not embedding aerolab in aerolab to keep the binary size small. Instead consider adding the different required binaries to the installer deb/tgz/zip/rpm/pkg.

For example MacOS would have:
aerolab
aerolab.linux.amd64
aerolab.linux.arm64

And linux amd64 would have:
aerolab
aerolab.linux.arm64

and linux arm64 would have:
aerolab
aerolab.linux.amd64

Issue: aerolab would need an installer for windows to handle this. We don't currently have one per-se.

Alternative option is that aerolab would not come with alternate versions. It would instead go to the repo releases page and download the versions it needs from the releases API from github (cache for future use on first download). But that feels like an incomplete install for me.

Another alternative is to just leave it as it is.

@robertglonek robertglonek added the enhancement New feature or request label Jan 2, 2024
@robertglonek robertglonek added this to the 7.4.0 milestone Jan 2, 2024
@dotyjim-work
Copy link
Contributor

If/When the GOOS=cosmo existed, this would be interesting :: APE + golang/go/issues/51900

@robertglonek robertglonek removed this from the 7.4.0 milestone Jan 6, 2024
@robertglonek robertglonek added this to the 8.0.0 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants