Notify user when has a new version #107
Conversation
| @@ -40,3 +43,7 @@ export const verifyYeoman = async () => { // eslint-disable-line import/prefer-d | |||
|
|
|||
| return true; | |||
| }; | |||
|
|
|||
| export const verifyVersion = async () => { // eslint-disable-line import/prefer-default-export | |||
There was a problem hiding this comment.
There's no need for the eslint-disable-line comment, it will no longer throw an error on this file since there are two exports, it's better to remove both of the comments.
There was a problem hiding this comment.
Also, since it is a one-line function, use a shorthand removing the async/await, brackets & return syntaxes.
| @@ -40,3 +43,7 @@ export const verifyYeoman = async () => { // eslint-disable-line import/prefer-d | |||
|
|
|||
| return true; | |||
| }; | |||
|
|
|||
| export const verifyVersion = async () => { // eslint-disable-line import/prefer-default-export | |||
| return await updateNotifier({pkg}).notify(); | |||
There was a problem hiding this comment.
That way the notification will only work for the create-graphql package, this repo contains a Lerna project with both create-graphql (the CLI) and generator-graphql (the Yeoman generator that scaffolds the code), it's better to verify both of them since they can all be updated individually.
I also happened to run into an issue by trying to use update-notifier asynchronously, so I think it's better to use the callback function and a small check: https://github.com/lucasbento/reminders-cli/blob/master/src/utils/updateNotifier.js#L10-L13 (sindresorhus/update-notifier#67 (comment)).
Closes #77