Update LINSTOR v1.29.2 #494
Conversation
dosubot
bot
added
the
size:M
WalkthroughThe pull request includes several updates to the Piraeus Operator Helm chart. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/system/piraeus-operator/charts/piraeus/templates/deployment.yaml (1)
96-97: LGTM! Consider documenting the new values in values.yamlThe addition of
nodeSelectorandaffinityfields enhances pod scheduling control. The implementation correctly uses Helm values for configuration.Consider adding documentation for these new values in the chart's values.yaml file, including:
- Expected format
- Example configurations
- Default values
Also applies to: 100-101
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
packages/system/piraeus-operator/charts/piraeus/Chart.yaml(1 hunks)packages/system/piraeus-operator/charts/piraeus/templates/config.yaml(2 hunks)packages/system/piraeus-operator/charts/piraeus/templates/crds.yaml(2 hunks)packages/system/piraeus-operator/charts/piraeus/templates/deployment.yaml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/system/piraeus-operator/charts/piraeus/Chart.yaml
🔇 Additional comments (3)
packages/system/piraeus-operator/charts/piraeus/templates/config.yaml (2)
48-48: LGTM! More specific RHEL pattern
The pattern change from Red Hat Enterprise Linux 7\. to Red Hat Enterprise Linux Server 7\. makes the matching more specific.
20-20: Verify compatibility of version updates
The following version updates have been made:
- linstor-controller/satellite: v1.29.1 -> v1.29.2 (patch)
- linstor-csi: v1.6.3 -> v1.6.4 (patch)
- drbd-reactor: v1.4.1 -> v1.6.0 (major)
- ha-controller: v1.2.1 -> v1.2.2 (patch)
- drbd-module-loader: v9.2.11 -> v9.2.12 (patch)
Special attention should be paid to the drbd-reactor update as it's a major version jump.
Also applies to: 24-24, 27-27, 30-30, 33-33, 42-42
packages/system/piraeus-operator/charts/piraeus/templates/crds.yaml (1)
833-845: LGTM! Well-structured IP family support
The addition of the ipFamilies field to both LinstorSatelliteConfiguration and LinstorSatellite CRDs is well-implemented:
- Clear documentation
- Proper validation with IPv4/IPv6 enum
- Maintains backward compatibility
- Consistent implementation across both CRDs
Also applies to: 1442-1454
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Updated Piraeus Operator chart to version 2.7.1. - Introduced new Custom Resource Definitions (CRDs) for enhanced management of LINSTOR resources. - **Improvements** - Updated image tags for various components to their latest versions. - Added `nodeSelector` and `affinity` fields for improved pod scheduling in deployments. These enhancements provide users with better resource management and operational capabilities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary by CodeRabbit
Release Notes
New Features
Improvements
nodeSelectorandaffinityfields for improved pod scheduling in deployments.These enhancements provide users with better resource management and operational capabilities.