Add passwords generation to ClickHouse #332
Conversation
|
Warning Rate limit exceeded@kvaps has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 26 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes involve an update to the Clickhouse application, incrementing its version from Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Clickhouse
participant KubernetesSecret
participant PasswordGenerator
User->>Clickhouse: Request user credentials
Clickhouse->>KubernetesSecret: Retrieve existing credentials
KubernetesSecret-->>Clickhouse: Return credentials
Clickhouse->>PasswordGenerator: Generate password if none provided
PasswordGenerator-->>Clickhouse: Return generated password
Clickhouse->>KubernetesSecret: Create/update secret with credentials
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- packages/apps/clickhouse/Chart.yaml (1 hunks)
- packages/apps/clickhouse/templates/clickhouse.yaml (2 hunks)
- packages/apps/clickhouse/templates/dashboard-resourcemap.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/apps/clickhouse/Chart.yaml
Additional context used
yamllint
packages/apps/clickhouse/templates/dashboard-resourcemap.yaml
[error] 4-4: syntax error: expected , but found ''
(syntax)
packages/apps/clickhouse/templates/clickhouse.yaml
[error] 1-1: syntax error: expected the node content, but found '-'
(syntax)
[warning] 6-6: wrong indentation: expected 0 but found 4
(indentation)
[warning] 7-7: wrong indentation: expected 0 but found 2
(indentation)
[warning] 11-11: wrong indentation: expected 0 but found 2
(indentation)
[warning] 12-12: wrong indentation: expected 0 but found 4
(indentation)
[warning] 13-13: wrong indentation: expected 0 but found 2
(indentation)
[warning] 14-14: wrong indentation: expected 0 but found 4
(indentation)
[warning] 15-15: wrong indentation: expected 0 but found 2
(indentation)
[warning] 25-25: wrong indentation: expected 0 but found 2
(indentation)
Additional comments not posted (5)
packages/apps/clickhouse/templates/dashboard-resourcemap.yaml (1)
1-19: LGTM! The Kubernetes Role configuration looks good.The file defines a Kubernetes Role named
{{ .Release.Name }}-dashboard-resourcesthat grants specific permissions:
get,list, andwatchpermissions on thechi-clickhouse-test-clickhouse-0-0service resource.get,list, andwatchpermissions on the{{ .Release.Name }}-credentialssecret resource.The configuration follows the expected structure for defining rules and permissions in a Kubernetes Role.
Regarding the yamllint hint:
[error] 4-4: syntax error: expected <block end>, but found '<scalar>'This appears to be a false positive, as line 4 is correctly formatted. You can safely ignore this hint.
Tools
yamllint
[error] 4-4: syntax error: expected , but found ''
(syntax)
packages/apps/clickhouse/templates/clickhouse.yaml (4)
1-8: LGTM!The code changes for retrieving the existing Kubernetes Secret and decoding the user credentials are approved.
Tools
yamllint
[error] 1-1: syntax error: expected the node content, but found '-'
(syntax)
[warning] 6-6: wrong indentation: expected 0 but found 4
(indentation)
[warning] 7-7: wrong indentation: expected 0 but found 2
(indentation)
10-16: LGTM!The code changes for handling user passwords are approved. The logic for generating random passwords when no password is provided is a good security practice.
Tools
yamllint
[warning] 11-11: wrong indentation: expected 0 but found 2
(indentation)
[warning] 12-12: wrong indentation: expected 0 but found 4
(indentation)
[warning] 13-13: wrong indentation: expected 0 but found 2
(indentation)
[warning] 14-14: wrong indentation: expected 0 but found 4
(indentation)
[warning] 15-15: wrong indentation: expected 0 but found 2
(indentation)
18-27: LGTM!The code changes for creating the Kubernetes Secret with user credentials are approved. The Secret is correctly named and populated with the required data.
Tools
yamllint
[warning] 25-25: wrong indentation: expected 0 but found 2
(indentation)
63-63: LGTM!The code change for accessing the storage class value using the correct scope is approved.
Signed-off-by: Andrei Kvapil <[email protected]>
kvaps
force-pushed
the
clickhouse-random
branch
from
42a4625 to
a6be560
Compare
Signed-off-by: Andrei Kvapil [email protected]
Summary by CodeRabbit
New Features
Bug Fixes