Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fluent-bit and VictoriaLogs #305

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Add fluent-bit and VictoriaLogs #305

merged 2 commits into from
Aug 29, 2024

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Aug 28, 2024 •
edited by coderabbitai bot
Loading

Screenshot 2024-08-28 at 15-10-20 Explore - vlog-generic - Grafana

@kvaps
Add fluent-bit and VictoriaLogs
0f4d416 
Signed-off-by: Andrei Kvapil <[email protected]>
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Warning

Walkthrough skipped

File diffs could not be summarized.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

kvaps
kvaps commented Aug 28, 2024
View reviewed changes
packages/extra/monitoring/values.yaml
- name: generic
retentionPeriod: "1m"
storage: 10Gi
storageClassName: replicated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default it uses replicated storageClass, due to fact vlog can't run as cluster for now

gecube
gecube reviewed Aug 28, 2024
View reviewed changes
packages/extra/monitoring/templates/grafana/grafana.yaml
deployment:
spec:
replicas: 2
template:
spec:
initContainers:
- name: "load-vm-ds-plugin"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to build custom image as there could be no internet access (prepare for airgap)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or just use a VolumeSource from the latest kubernetes and use the power of OCI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, I'll add an issue for this #306

@gecube
Copy link
Collaborator

gecube commented Aug 28, 2024

  1. Where is the victoria metrics
  2. My recommendation: throw away victoria single logs chart and switch to victoria operator - it is capable of installation VM and VLogs simultaneously or separatly.

@kvaps
Copy link
Member Author

kvaps commented Aug 28, 2024 •
edited
Loading

throw away victoria single logs chart and switch to victoria operator - it is capable of installation VM and VLogs simultaneously or separatly.

Cool, I didn't know that. Thank you for your note, PR rebased to use victoria-metrics-operator to install vlogs

@kvaps kvaps requested a review from gecube August 28, 2024 18:10
@kvaps kvaps merged commit adaf603 into main Aug 29, 2024
@kvaps kvaps deleted the vlog branch August 29, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gecube gecube Awaiting requested review from gecube

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvaps @gecube