Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json scripts to define separate manifest.json files for Chrome and Firefox #4

Open
aeksco opened this issue Jan 27, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aeksco
Copy link
Owner

aeksco commented Jan 27, 2020

Got this reply in an /r/react thread:

Nice. I kept looking and looking where you generate the different manifest.json files. But it looks like you used a combined one.

Be aware that there are slight differences in FF and Chrome supported extensions. So I had to keep separate manifest.json files for each browser.

The problem is that each of the browsers doesn't load the extension if the manifest contains invalid stuff that the other one supports ( e.g. optional permissions, or unsupported permissions )

I am on mobile now so difficult for me to diff. But you can see the subtle differences here :

https://github.com/stefanXO/Tab-Manager-Plus/blob/master/manifest.json

https://github.com/stefanXO/Tab-Manager-Plus/blob/master/manifest-firefox.json

There should be separate yarn build:firefox and yarn build:chrome scripts (instead of just having yarn build) that can copy a different source manfiest.json file to account for small variations between the two different browsers.

@aeksco aeksco added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant