src: fix crash with SyntheticModule#setExport

Use the new non-deprecated V8 API for that. PR-URL: nodejs#30062 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95 · Jan 8, 2020 · 69afd66 · 69afd66
1 parent abcc819
commit 69afd66
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/module_wrap.cc b/src/module_wrap.cc
@@ -1500,7 +1500,7 @@ void ModuleWrap::SetSyntheticExport(
   Local<Value> export_value = args[1];
 
   Local<Module> module = obj->module_.Get(isolate);
-  module->SetSyntheticModuleExport(export_name, export_value);
+  USE(module->SetSyntheticModuleExport(isolate, export_name, export_value));
 }
 
 void ModuleWrap::Initialize(Local<Object> target,

diff --git a/test/parallel/test-vm-module-synthetic.js b/test/parallel/test-vm-module-synthetic.js
@@ -36,8 +36,6 @@ const assert = require('assert');
     });
   }
 
-  // https://bugs.chromium.org/p/v8/issues/detail?id=9828
-  /*
   {
     const s = new SyntheticModule([], () => {});
     await s.link(() => {});
@@ -47,7 +45,6 @@ const assert = require('assert');
       name: 'ReferenceError',
     });
   }
-  */
 
   {
     const s = new SyntheticModule([], () => {});