Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synonyms update #2

Open
golnazads opened this issue Sep 24, 2024 · 1 comment
Open

Synonyms update #2

golnazads opened this issue Sep 24, 2024 · 1 comment

Comments

@golnazads
Copy link
Contributor

Conversation from the PR #1

adsplanetnamepipe/utils/common.py
class Synonyms(object):

# generated 5/20/2022
synonym_list = {

Member
@kelockhart kelockhart on Jul 25
How frequently do you see this being updated? If not very often, this is fine; otherwise consider moving to a config

Member
Author
@golnazads golnazads on Jul 26
Need to ask, I dont know the answer.

Update
I asked Alberto about this, and he said that he talked to you (Kelly) and also Taylor. I brought up the same issue on the side of resolver service with Taylor. Over there, I am one step closer. There are files on the server that Edwin modifies on a regular basis. They are called source matchers. Reading and processing them takes some time, so I do that offline, create a serializable object, and then load that every time the service is deployed.
I went through the motion, got files from the server, created a serializable object, uploaded it to GitHub, and asked Taylor to see if he could upload the serializable object to the pod without making a release. It was just before his vacation. He said he would think about it afterward.
So, I think I should do the same thing here as well: make a serializable object and update it on a regular basis. I will make an issue out of this and wait to see if it works for the resolver. If it does, then I’ll proceed this way; otherwise, I’ll go with another approach.

@kelockhart @tjacovich @aaccomazzi

@golnazads golnazads mentioned this issue Sep 24, 2024
@aaccomazzi
Copy link
Member

The synonym updates should be rare, since they concern only the solar system objects, which is a small and finite list. So I wouldn't sweat about automating the update, I would expect maybe a need for a once a year update at most.

For the source matchers we can expect weekly updates from the curators, so automating or streamlining that deployment is critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants