Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yamllint is now installed by default in GitHub actions virtual environments #300

Closed
yvele opened this issue Aug 18, 2020 · 7 comments
Closed

Comments

@yvele
Copy link

yvele commented Aug 18, 2020

Just to let you know that yamllint is now installed by default in GitHub actions virtual environments

See actions/runner-images#1142 🎉

This may be helpful to be mentioned in the docs

@adrienverge
Copy link
Owner

Thanks @yvele, good news!

Unfortunately this relies on the .deb package, which is not actively maintained. The installed version is 1.10.0, whereas the latest is 1.24.2 (it has lots of bugfixes and new features).

Do you know if it's easy to switch to pip on GitHub actions?

@yvele
Copy link
Author

yvele commented Aug 18, 2020

Yep I've noticed that the yamllint version on GitHub actions is 1.10.0 🤔

Unfortunately in my issue I suggested using apt get.. I didn't noticed that .deb package was so out to date... see https://github.com/actions/virtual-environments/pull/1319/files

We have 2 options:

What do you think?

@adrienverge
Copy link
Owner

I'm for using pip: even if someone dedicates time to actively maintain the deb package, it will always be late compared to the PyPi version (which is pushed a few seconds after a release is created).

@ssbarnea
Copy link
Contributor

@yvele You are much better switching to wheels instead of system packages. System ones are always outdated, even those that have active packagers they lack behind, sometimes with years. For pure-python packages, wheels are the way.

@yvele
Copy link
Author

yvele commented Sep 24, 2020

I've filled an issue in the GitHub Actions virtual environments repo actions/runner-images#1657 😉

@yvele
Copy link
Author

yvele commented Oct 28, 2020

yamllint is installed properly on GitHub Actions 👏 actions/runner-images#1657 (comment)

@yvele yvele closed this as completed Oct 28, 2020
@adrienverge
Copy link
Owner

Thanks @yvele!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants