Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS REVIEW] Installation instructions #38

Closed
tkchafin opened this issue Dec 6, 2023 · 3 comments · Fixed by #43
Closed

[JOSS REVIEW] Installation instructions #38

tkchafin opened this issue Dec 6, 2023 · 3 comments · Fixed by #43

Comments

@tkchafin
Copy link

tkchafin commented Dec 6, 2023

Are the installation instructions correct? I can't get installation to work without first manually installing dada2 and phyloseq

if (!require("BiocManager", quietly = TRUE))
  install.packages("BiocManager")

BiocManager::install("dada2")
BiocManager::install("phyloseq")
@adrientaudiere
Copy link
Owner

You are right. I tried on a docker image, and we effectively needed this code before. I saw no direct solution for the moment. In a discussion on stackoverflow they suggest using BiocManager::install(MiscMetabar), but until MiscMetabar is only available on GitHub, there is no obvious solution. I plan to submit MiscMetabar to CRAN during the next summer.

I updated the README file to better explain the installation. Thanks for the time you spent on my submission.

@tkchafin
Copy link
Author

tkchafin commented Dec 6, 2023

Sounds good, that's all I had intended as the fix, just to make sure the documentation was accurate

@iimog
Copy link
Contributor

iimog commented Dec 12, 2023

After merging the pr #43, these instructions are no longer required in the README:

if (!require("BiocManager", quietly = TRUE))
  install.packages("BiocManager")

BiocManager::install("dada2")
BiocManager::install("phyloseq")

It does not hurt to run these commands beforehand, it's just not necessary anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants