Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Customer already exists" error not handled gracefully #102

Closed
lukawski opened this issue Oct 12, 2023 · 4 comments · Fixed by #103
Closed

"Customer already exists" error not handled gracefully #102

lukawski opened this issue Oct 12, 2023 · 4 comments · Fixed by #103

Comments

@lukawski
Copy link

Hey! Thanks for this great and convenient plugin!

I stumbled upon one problem which is a bug. The steps to reproduce are:

  1. Set up at least 2 different providers - in my case, those are Google and Facebook
  2. You need to have an account for each provider with the same email. In my case, my Google & Facebook account both use my email [email protected].
  3. Create an account using store endpoint using the first provider - Facebook
  4. Sign out and try to create another account using the second provider - Google
  5. Error is thrown in the store endpoint but, it doesn't use failure redirect. It just throws an error directly into the browser.
image

Package versions

"@medusajs/medusa": "1.16.1",
"medusa-plugin-auth": "^1.6.0",
@adrien2p
Copy link
Owner

Thanks for reporting it, i ll attend to it as soon as I can 👍

@adrien2p
Copy link
Owner

I will have a look sometime today yo fix this 🤞

@adrien2p
Copy link
Owner

@lukawski could you have a look at this one please #103

@lukawski
Copy link
Author

Hey @adrien2p, sorry for the late answer. Looks good to me, thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants