fix(medusa-config): dont run all functions immediately in medusa-config, only promises #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig, only promises
adrien2p
reviewed
Jan 19, 2023
src/core/utils.ts
Outdated
| @@ -83,6 +83,9 @@ export function buildRegexpIfValid(str: string): RegExp | undefined { | |||
| return; | |||
| } | |||
|
|
|||
| export const isPromise = (obj: any): boolean => | |||
There was a problem hiding this comment.
todo: could you type it as unknown and see if that is ok.
|
seams reasonable to me 💪 thanks man |
|
Can I get you to update the test accordingly please? |
|
@dwene any news? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of running everything with
key[obj] === functionand setting the value is breaking plugins that require you to pass functions.Now we only await promises, not all functions.