-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers): add ability to register tax and fulfillment providers using medusa-extender annotations #146
Conversation
…s using medusa-extender annotations
@adrien2p ok I added some unit and integration tests! I'd like to start with these 2 fulfillment providers for now, but I'm setting up patterns here to be used again for payment, search, notification, file, oauth, and other future providers! |
Also this closes #128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice, Can I get you to resolve the codeQL comment as well and mine and it should be ready to merge 🚀
|
||
export type AllowedProviderInjectableOptions = Omit<ProviderInjectableOptions, 'subtype'>; | ||
/** | ||
* Mark a class as an entity to be used by the loader. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: update
src/loaders/plugins.loader.ts
Outdated
import { customEventEmitter } from '../core'; | ||
import { customEventEmitter, GetInjectableOptions } from '../core'; | ||
import { registerProviders } from './providers.loader'; | ||
import { container } from 'webpack'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: rm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Sweet! Let's ship it! |
@dwene i ve merged it. Can I get you to update the doc please? |
No description provided.