Display update version in the homescreen update tooltip #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriankumpf
pushed a commit
that referenced
this pull request
Oct 8, 2020
* Make update_version of the API available * Add update version to the update tooltip * Fix formatting * Update translations to reflect the new tooltip * Fix car controller test * Add update_version to the mqtt documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an update is available the version should be known and shown in the icon tooltip, which closes #943.
Maybe we should not show the parantheses if the version is not available for some reason
If there is anything wrong with the formatting/localization/anything else, just let me know.