Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added links Statistics again #973

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Added links Statistics again #973

merged 4 commits into from
Oct 13, 2020

Conversation

DrMichael
Copy link
Collaborator

@DrMichael DrMichael commented Oct 5, 2020

Some smaller changes:

  • the should be invisible fields moved to the far right and made them small
  • added panel title to be able to sort by clicking the column header
  • timezone back to current_setting, given that you can set it via PGTZ in the Grafana container

I moved the should be invisible fields to the far right and minimised them... As soon as that is fixed in Grafana, we can just make them invisible.

The only thing, which is not optimal, is, that the fields with mi and F show up at the far right. No idea, how to address that...
Given, that it can be set via PGTZ.
Otherwise you cannot sort by clicking the column header...
Copy link
Collaborator

@adriankumpf adriankumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using invisible fields is a simple workaround 👍

@@ -696,16 +748,16 @@
"value": "GMT"
},
"datasource": "TeslaMate",
"definition": "select name from pg_timezone_names where name like 'posix/%';",
"definition": "SELECT current_setting('TIMEZONE');",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subsequently changing the timezone via PGTZ does not work for me.

Could both approaches be combined? Then a meaningful timezone could be preselected, but one would still have the possibility to change the timezone.

Copy link
Collaborator Author

@DrMichael DrMichael Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subsequently changing the timezone via PGTZ does not work for me.

You have set it for the Grafana container? (Not the Database one!)

Could both approaches be combined? Then a meaningful timezone could be preselected, but one would still have the possibility to change the timezone.

Well, "select current_setting('TIMEZONE'), name from pg_timezone_names where name like 'posix/%';" should do it. It does for my changed version, it does not for the "official" version. Whyoever...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have set it for the Grafana container? (Not the Database one!)

Oh, that worked! Okay, let's make the time zone configurable then but default to the current time zone setting.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that's fine... And links as soon as the hidden fiels issue is fixed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that'd be great. I hope they will fix it soon!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw, you have the links in. So, then it is only needed to hide the two fields, when it is fixed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry that's what I meant. Those almost invisible fields are fine for now.

@adriankumpf adriankumpf merged commit 8db65f7 into teslamate-org:master Oct 13, 2020
adriankumpf added a commit that referenced this pull request Oct 14, 2020
* Added links again

I moved the should be invisible fields to the far right and minimised them... As soon as that is fixed in Grafana, we can just make them invisible.

The only thing, which is not optimal, is, that the fields with mi and F show up at the far right. No idea, how to address that...

* And changed timezone back to current_setting

Given, that it can be set via PGTZ.

* Added panel title

Otherwise you cannot sort by clicking the column header...

* Make time zone configurable again; preselect current TZ

Co-authored-by: Adrian Kumpf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants