Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Customize" Grafana logo #890

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Conversation

fatbasstard
Copy link
Contributor

Couldn't help it, had to do it (close the PR if you want).

This PR replaces the Grafana logo (and favicon) with the Teslamate logo:

image

I always get confused with the Grafana I'm looking at (working with multiple Grafana's), let's make the Teslamate Grafana look like Teslamate. 😛

(Images are "copies" from the assets/static folder)

Copy link
Collaborator

@adriankumpf adriankumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic idea! Thank you.

@adriankumpf adriankumpf merged commit a4b3cd6 into teslamate-org:master Sep 1, 2020
@Turbourpo
Copy link
Contributor

Hey, I have saved the teslamate grafana site as "shortcut" to my iOS home screen. Looks like this change did not have any impact to it even though I recreated it to the home screen. Is there anyone who has the ability dig around where the Safari pulls the icon? Or it might be the case that the old icon is still in my phone's cache.

image

@adriankumpf
Copy link
Collaborator

I also get the original Grafana icon. Safari seems to require an icon marked as apple-touch-icon:

https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html

@Turbourpo
Copy link
Contributor

That kind of approach did not cross my mind so I didn’t even bother to google for solution. Now when googling around the approach, looks like similar change would also work for androids.

@Turbourpo
Copy link
Contributor

So the solution would be to resize the existing teslamate icon to the needed pixel sizes, then in graphana’s Dockerfile copy them to right place and echo the safari ”Web Clip” and similar android details to the web template which loads for example the favicon image.

@adriankumpf
Copy link
Collaborator

We should already have the icons: https://github.com/adriankumpf/teslamate/tree/master/assets/static If you have found the "right place", a PR would be very much appreciated :-)

@Turbourpo
Copy link
Contributor

Ah, looks like all the pieces needed exist already. The grafana even has the "apple specific" label in the page source, it is just a matter of copying the apple-touch-icon.png from the teslamate assets source to the public/img/ directory of graphana in graphanas Dockerfile. I'll try to carry out the PR. ..I am a newbie with this github.

adriankumpf pushed a commit that referenced this pull request Oct 13, 2020
Replace existing grafana logo with teslamate logo for apple devices. Enhances existing #890 PR.
adriankumpf pushed a commit that referenced this pull request Oct 14, 2020
Replace existing grafana logo with teslamate logo for apple devices. Enhances existing #890 PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants