Update updates.json #632
Merged
Update updates.json #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added duration and time since last update as requested in adriankumpf#617
baylanger
reviewed
Apr 23, 2020
grafana/dashboards/updates.json
Outdated
| @@ -144,7 +144,7 @@ | |||
| "group": [], | |||
| "metricColumn": "none", | |||
| "rawQuery": true, | |||
| "rawSql": "select start_date, end_date, version from updates where $__timeFilter(start_date) and car_id = $car_id;", | |||
| "rawSql": "select start_date, end_date, date_trunc('second',end_date-start_date) as update_duration, date_trunc('second',start_date-lag(start_date) over ( order by start_date)) as since_last_update , version from updates where $__timeFilter(start_date) and car_id = $car_id; ", | |||
There was a problem hiding this comment.
Missing 1 space... not sure if json parsing will be happy about it, likely a good idea to add that space back. There's a space not necessary at the end of the line, perhaps that's where the missing space in the beginning ended up?
There was a problem hiding this comment.
Not sure where specifically you mean. This ran fine in grafana. Was a export straight from my grafana.
Corrected space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added duration and time since last update as requested in adriankumpf#617