Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default.po #598

Merged
merged 8 commits into from
Apr 19, 2020
Merged

Update default.po #598

merged 8 commits into from
Apr 19, 2020

Conversation

tomS3210
Copy link
Contributor

Update of the French Translation :

  • Added : Some missing translations
  • Changed : Improved translation

Update of the French Translation :
- Added : Some missing translations
- Changed : Improved translation
Copy link
Contributor

@MaxG88 MaxG88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some thoughts/suggestions.
The French translation is indeed in dire need of an update.

priv/gettext/fr/LC_MESSAGES/default.po Outdated Show resolved Hide resolved
priv/gettext/fr/LC_MESSAGES/default.po Outdated Show resolved Hide resolved
priv/gettext/fr/LC_MESSAGES/default.po Outdated Show resolved Hide resolved
@@ -295,7 +295,7 @@ msgstr "Mise à jour en cours"
#, elixir-format
#: lib/teslamate_web/templates/car/summary.html.leex:52
msgid "Windows open"
msgstr "Vitre ouverte"
msgstr "Vitres ouvertes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Vitres ouvertes"
msgstr "Fenêtres ouvertes"

It might be a personal preference thing, but I feel like I more often hear "Fenêtre" when talking about a car window than "Vitre". Might be different in France.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In France we used to say "Vitres de voiture", "Vitre ouverte", "Vitre teintées" ...

priv/gettext/fr/LC_MESSAGES/default.po Outdated Show resolved Hide resolved
priv/gettext/fr/LC_MESSAGES/default.po Outdated Show resolved Hide resolved
priv/gettext/fr/LC_MESSAGES/default.po Outdated Show resolved Hide resolved
priv/gettext/fr/LC_MESSAGES/default.po Outdated Show resolved Hide resolved
@adriankumpf adriankumpf merged commit a99f6c4 into teslamate-org:master Apr 19, 2020
@adriankumpf
Copy link
Collaborator

Thank you!

@tomS3210
Copy link
Contributor Author

Thanks for the Merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants