Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Danish translation #584

Merged

Conversation

MartinNielsen
Copy link
Contributor

No description provided.

@adriankumpf
Copy link
Collaborator

Awesome. Thank you!

@adriankumpf adriankumpf merged commit b2cae9f into teslamate-org:master Apr 14, 2020
@MartinNielsen MartinNielsen deleted the Add-Danish-translation branch April 16, 2020 09:51
@jmiverson
Copy link
Contributor

@adriankumpf — Is there a template for language support somewhere that folks are using? I noticed that this latest language file doesn’t have the new “msgid” values that I updated in my PR last week, which I think will cause the translation to not take for those labels.

If there’s a template, I probably need to update that as well. Otherwise, I can run through this new Danish file and update them like I had done for the others. Just don’t want it to become a perpetual problem.

Here’s my PR for reference: #578

@DrMichael
Copy link
Collaborator

Well, @adriankumpf probably extracts the messages with "xgettext". Then the result of that has to be merged with the existing translations with "msgmerge".
I have that automated in one of my projects through a Makefile, but cannot access that currently.

@adriankumpf
Copy link
Collaborator

Yes, gettext (mix gettext.extract --merge) is used to extract/remove translations. Merging translations works quite well most of the time. I've done this after merging this PR so it should have picked up the updated labels:

https://github.com/adriankumpf/teslamate/blob/a99f6c4a3acf9d14f595d748199a8475891504ce/priv/gettext/da/LC_MESSAGES/default.po#L14-L572

@larskochhansen
Copy link
Contributor

Hi. I know that this translation issue may be a bit "old" but there are 2 words that should be changed if possible. I do not know how to do this but they are actually easy to locate in the above code.

Line 42: Opladet
instead of "lader"

Line 346: Oversigter
instead of oversikter - spelling error.

Is this possible to implement in a future update :) Thanks in advance and thanks for this amazing software development.

@adriankumpf
Copy link
Collaborator

If you want, you can propose those changes directly using the GitHub web interface @larskochhansen . The file with the Danish translations is located here: https://github.com/adriankumpf/teslamate/blob/master/priv/gettext/da/LC_MESSAGES/default.po

And here is a guide on how to edit files and open PR: https://docs.github.com/en/github/managing-files-in-a-repository/editing-files-in-your-repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants