Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs to include wake proxy example for apache #405

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

DP19
Copy link
Contributor

@DP19 DP19 commented Jan 28, 2020

Just finished setting this up from scratch and it was hard to tell you actually needed to set this up if you didn't read the docs to carefully. I looked through the docs for traefik to see if there was an easy label to set for the http router to proxy this as well but didn't see anything obvious. If someone wants to add that, it would also be useful and I imagine most people would like this enabled by default.

As a side note it looks like the docs for the wake integration are pretty different as the ios docs are the only ones that mention proxy'ing an endpoint like this.

@DP19 DP19 requested a review from adriankumpf January 28, 2020 20:08
@adriankumpf
Copy link
Collaborator

adriankumpf commented Jan 29, 2020

I wonder if we shouldn't change the URL mentioned in the iOS guide instead, to keep it simple:

`https://teslamate.example.com/wake` -> `https://teslamate.example.com/api/car/1/logging/resume`

Proxying should not be necessary, it was just used as an example by the original contributor of the guide iirc.

@adriankumpf adriankumpf merged commit e2bf13a into teslamate-org:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants